test: cover sqlite statements after database close#62978
Closed
umuoy1 wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62978 +/- ##
==========================================
- Coverage 91.94% 90.05% -1.89%
==========================================
Files 362 714 +352
Lines 155999 225242 +69243
Branches 24057 42582 +18525
==========================================
+ Hits 143429 202849 +59420
- Misses 12295 14187 +1892
- Partials 275 8206 +7931 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi, just wanted to check if someone from @nodejs/sqlite could take a look at this when they have time. This is a test-only PR for node:sqlite, adding coverage for StatementSync and iterators after DatabaseSync.close() / Symbol.dispose. If this looks reasonable, could someone also help start CI? Thanks! |
umuoy1
force-pushed
the
test-sqlite-close-invalidates-statements
branch
from
81d2d8f to
ad0690e
Compare
Contributor
|
I think there's already two other PRs that implement this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds coverage for
DatabaseSyncclosing behavior with existing prepared statements.The tests verify that after
close()or[Symbol.dispose]():prepare()andexec()report that the database is not openStatementSyncinstances report that the statement has been finalized